search

Nitrokey / pynitrokey

Python client for Nitrokey devices
Apache License 2.0
93 stars 28 forks source link

secrets: Handle devices without the secrets app #408

Open robin-nitrokey opened 1 year ago

robin-nitrokey commented 1 year ago

As far as I see, using any of the command method of SecretsApp will cause a CtapError if the secrets app is not available on the device. This should be handled by pynitrokey and a exception that does not depend on the transport layer and that can be easily identified should be used instead.

szszszsz commented 1 year ago

Does it make sense though? I think the policy is to not support outdated firmware, hence it was not added. Please correct me otherwise.

robin-nitrokey commented 1 year ago

I’d just like to have a simple way to show a proper message in the UI for this specific cases instead of just catching all exceptions and interpreting them as missing secrets support.