Closed cesasol closed 10 years ago
There are already guidelines for them, they're in the flattr-guidelines folder.
since i'm new to using git i also have a question: Do i make a branch and then push that and after someone has checked it it's merged or do i just make changes to the master?
@pacomaro What I usually do and I'm no expert either, is, I clone the repo, I make my changes and then push them, in your case if you make your changes in master and you create a pull request, I can review the changes and comment on them, if they are ok then your changes are merged.
ok. So the pull request would be done on that sidepane on GitHub, right?
By the way, the page linked for the golden ratio calculator has no input box anywhere...
On Mon, Apr 21, 2014 at 7:53 PM, Uri Herrera notifications@github.comwrote:
What I usually do and I'm no expert either, is, I clone the repo, I make my changes and then push them, in your case if you make your changes in master and you create a pull request, I can review the changes and comment on them, if they are ok then your changes are merged.
— Reply to this email directly or view it on GitHubhttps://github.com/NitruxSA/flattr-icons/issues/12#issuecomment-40964047 .
Francisco Mariz Rodrigues
http://p http://blog.pacomaro.comacomaro.tumblr.com
@pacomaro Hmm strange but I've found another http://elliotwaite.com/golden-ratio-calculator/ - input the number and check "round to integer".
Yes it can be done either from the site or from the terminal.
about the pull request. Do i have to push the changes from my end to compare them? If so, I'll push the master branch?
On Mon, Apr 21, 2014 at 8:20 PM, Uri Herrera notifications@github.comwrote:
@pacomaro https://github.com/pacomaro Hmm strange but I've found another http://elliotwaite.com/golden-ratio-calculator/ - input the number an check "round to integer".
— Reply to this email directly or view it on GitHubhttps://github.com/NitruxSA/flattr-icons/issues/12#issuecomment-40966718 .
Francisco Mariz Rodrigues
http://p http://blog.pacomaro.comacomaro.tumblr.com
Yes you have to push the changes from your end (branch) to master.
ok. thanks. sorry about the noob issues
On Wed, Apr 23, 2014 at 7:35 PM, Uri Herrera notifications@github.comwrote:
Yes you have to push the changes from your end (branch) to master.
— Reply to this email directly or view it on GitHubhttps://github.com/NitruxSA/flattr-icons/issues/12#issuecomment-41198004 .
Francisco Mariz Rodrigues
http://p http://blog.pacomaro.comacomaro.tumblr.com
@cesasol KDE games VBA-M and KRDC needs urgently a new icon, for the VBA-M's flattr icon I recommend a flat version of the official version of it's icon a purple GBA with the same details of the original like the batery indicator or the Nintendo and Gameboy advance logos but flat, the icon's name is vbam; for the KDE games use the original ones as base but not at all, for example kapman with a retro pacman Ksame with a flat Same gnome icon Kgoldrunner with a yellow flat running person or Kblocks with the classic tetris blocks; my suggestion is a cool combination of the flat design the original logos and classic elements about the game like pacman or the GBA; everything smooth and beautyfull
Thanks by colaborating
@sergioad unlike what Kaos has done the Flattr icons are not 1:1 flat replicas of the original icons of the applications, that completely defeats the purpose of a 3rd party icon theme. Flattr clearly has common grounds in the icons, icons that don't follow them won't be accepted here.
Oh I see @UriHerrera understod; I mean keep the original styles adding more and making them flat :)
As there's already a guidelines file in flattr-guidelines folder this issue is resolved, the file however needs to get a bit updated.
Well, I decided to support this project and some rules to follow at the time of designing icons will be amaizing