search

Niuslar / Multichannel-Temperature-Control

5 stars 3 forks source link

Manually build push image to ghcr #110

Closed duduta closed 2 years ago

duduta commented 2 years ago

Hi, this is an attempt to solve issue #49. The job I added can be triggered via "Actions", the "Select workflow" button, "Run workflow" dropdown, "Run workflow" green button.

Vavat commented 2 years ago

@FrozenOxide, @Niuslar, this one is for you to review. Nico, you'll need to approve the contributor too.

Vavat commented 2 years ago

@duduta, one comment from me is that commit messages should in in present tense. You are describing what commit does. I know it seems like a minor point, but this is the convention everyone is following and it makes it easier to comprehend what's happening.

duduta commented 2 years ago

@Vavat, thank you, I rebased my commit messages. Let me know if you have further suggestions.

Vavat commented 2 years ago

@Vavat, thank you, I rebased my commit messages. Let me know if you have further suggestions.

This wasn't strictly necessary, but well done. I poked those in the team better qualified to review your commits. Nico is on holiday I believe and Frozen is probably busy rebuilding his house. Let's wait till they return. In the meantime, feel free to pick other tickets.

MAhmedDev commented 2 years ago

@duduta Unable to see what passing pipeline looks like. Could you trigger the pipeline on the forked repo?

MAhmedDev commented 2 years ago

@Niuslar duduta may need to be registered as a contributor.

Niuslar commented 2 years ago

@FrozenOxide @duduta Sorry I've been busy. I'll look at it this evening.