Inner loop

[duduta]

Hi, This is an attempt to better separate the inner loop from the outer-loop, inspired by this article (it is about DockerHub registry, but I think it applies to GitHub registry as well): https://www.docker.com/blog/best-practices-for-using-docker-hub-for-ci-cd/

Inner-loop:

• build local docker image
• build app from local image

Outer-loop: taken care of by the workflows in github.

In case we want to use the official latest ghcr image to test the latest binary (both debug and release, present in ./Debug and ./Release folders)

• pull latest image from ghcr
• build app from latest image

Some questions remain:

1. do we still need to push/pull to/from DockerHub? Could that code be deleted?
2. does anybody from the team use "make all"? I was thinking to define it to do the inner-loop plus doxy-doc. Is that ok?

[Niuslar]

Sorry I thought I left a comment the other day. I was away and didn't have time to look at this, I'll try to review it this evening.

[duduta]

It's all right, it was weekend after all :) No hurry, I'm working locally and don't depend on this merge, so take your time. Hope those changes help.

[MAhmedDev]

Hi @duduta we do not need to keep the docker hub uri if we have github registry working. We can use that for everything. docker-compose-local.yml can be deleted.

In the future rather than duplicating the docker-compose.yml files with minor changes you can override the base file by using: docker-compose -f file_name_1.yml -f file_name_2.yml build

[MAhmedDev]

do we still need to push/pull to/from DockerHub? Could that code be deleted? It can be deleted

does anybody from the team use "make all"? I was thinking to define it to do the inner-loop plus doxy-doc. Is that ok? make all sounds good, feel free to extend the Makefile.

[duduta]

Hi, @FrozenOxide, I made the changes you suggested. Feel free to tell me if there's anything else I should do. By the way, thanks for pointing out that I could override the docker-compose.yml file, I didn't know about that, I find it quite elegant.

[MAhmedDev]

Hi @duduta docker-compose.local.yml can be deleted since we will likely not use/update the docker hub version.

[duduta]

@FrozenOxide Oh, I only focused on changing the tag from "latest" to "local" and forgot to also edit its name and that created confusion.
This file is only needed in order to change that tag. It's not using DockerHub registry, it is only used for building/running the image locally, for the normal course of development. I chose to change the tag in order to see clearly, when using the "docker images" command, where did that image come from: was it built locally (my work in progress) or was it pulled from ghcr. Also, in order to avoid having to rebuild local/ pull latest every time I need to run either of them and the current image under the name ghcr.io/niuslar/stm-32-cubeide-headless:latest is not the one I need to run.

[MAhmedDev]

@duduta docker-compose.local.yml is redundant and can be deleted

[duduta]

@FrozenOxide ok, I did that