Nivekk / KOS

Fully programmable autopilot mod for KSP.
Other
80 stars 30 forks source link

-Added volume:selected and volume:freespace #171

Open raad287 opened 10 years ago

raad287 commented 10 years ago

Added selected volume and volume free space data, in response to the request in issue #153.

volume:selected returns the name of the selected volume as a string. I added it in the comments, but if the user hasn't selected a new volume, the cpu.selectedVolume.name returns blank. I added a quick fix there because I didn't want to start messing around too deeply in the code.

volume:freespace returns the freespace of the current volume as an int, no problems.

a1270 commented 10 years ago

It's usually a bad idea to do changes to master. If on windows i'd read the github docs and on linux is super simple. 'git branch ifixedsomething' followed by a 'git checkout ifixedsomething'. Make your changes. Before you do a commit make sure to 'git checkout kOS.csproj,' this means you'll need to edit the refs again but less pain for upstream. Follow this by a 'git push ifixedsomthing origin'. You can then pull request that branch via the web.

raad287 commented 10 years ago

Thanks for the info, I've used git plenty, but never to do any pulling or merging, just on my own. I'll fix it as soon as I can.

On Sat, Oct 26, 2013 at 2:53 AM, a1270 notifications@github.com wrote:

It's usually a bad idea to do changes to master. If on windows i'd read the github docs and on linux is super simple. 'git branch ifixedsomething' followed by a 'git checkout ifixedsomething'. Make your changes. Before you do a commit make sure to 'git checkout kOS.csproj,' this means you'll need to edit the refs again but less pain for upstream. Follow this by a 'git push ifixedsomthing origin'. You can then pull request that branch via the web.

— Reply to this email directly or view it on GitHubhttps://github.com/Nivekk/KOS/pull/171#issuecomment-27143176 .

Dunbaratu commented 10 years ago

Thanks. Looking forward to this in the next release.

Nivekk commented 10 years ago

I like it! But it looks like it's using the old structure method.

I'll make a proper VolumeInfo class for this.