search

Nivekk / KOS

Fully programmable autopilot mod for KSP.
Other
80 stars 30 forks source link

Kill rotation on steering. #227

Open a1270 opened 10 years ago

a1270 commented 10 years ago

Looking through the code and noticed KILL in steering.

lock steering to kill.

That doesn't invoke KillRotation() as you'd expect. Seeing it was from the initial commit. It may be left over cruft as it's never been documented and seems nonfunctional.

Nivekk commented 10 years ago

Correct, it's something I never got to work

a1270 commented 10 years ago

I will attempt to get it working else we should consider removing it. @Cilph seems to be using it in kOS integration and that could cause issues.

ghost commented 10 years ago

I'm doing what? I'm not using it at all :D.

a1270 commented 10 years ago

@Cilph am i misinterpreting what this is? Not the first time i've done that. https://github.com/Cilph/RemoteTech2/commit/4981936a5bb86c07f1b4d3f022db11bbb40bc7f0

ghost commented 10 years ago

Ah. Not using KillRotation. Rather SteerTowards ;).

a1270 commented 10 years ago

In that case i can't see why you'd use it instead of SAS. I'd vote for removing it. @Cilph while i have your ear, @palaslet has said he is up to helping with your quest of RT2 + kOS. He just needs the OK of @Nivekk.

Off to get some food and take a break from bugging people.

ghost commented 10 years ago

I've been working on kOS integration and thus far I have the autopilot working under connection loss by allowing autopilots to register as a "Sanctioned Pilot" that allows it to bypass the control restriction. Effectively giving the OnFlyByWire callback to my flight computer. I could however use someone with more knowledge of the kOS source to help out with the rest.

I don't use VesselSAS because it really, really sucks for autopiloting. It can keep an attitude but it is so underdamped that large (> 30 degree) shifts are impossible.

Anyhow, I'm on #kspmodders whenever I'm online.

ghost commented 10 years ago

Could I have the contact details for @palaslet?