search

Nividica / ThaumicEnergistics

A bridge between Thaumcraft and Applied Energistics.
MIT License
71 stars 65 forks source link

GUIs not correctly blocking other actions #389

Closed swoolcock closed 4 years ago

swoolcock commented 4 years ago

Describe the bug Parts' onActivate is returning false on client-side, which means that other client events can trigger. This is obvious when holding a block, as a ghost block will place in front of the part temporarily. It's even more obvious when playing on a server, since books will still open (Thauminomicon, etc.)

Steps to Reproduce Steps to reproduce the behavior:

  1. Hold a block and right click on any part from Thaumic Energistics (Arcane Terminal, Export Bus, etc.)

Expected behavior Client actions are blocked before opening the GUI (obvious as the punching animation will play).

Version Information

Versions as at commit: https://github.com/Nividica/ThaumicEnergistics/commit/199c73a0d7b19415df74abf40b4b4528cce607f1

Nividica commented 4 years ago

Stepping out of the shadows for a brief moment to accept this, and your other PR, and push out a build. Thank you for helping out :D