search

Nivmizzet95 / handle_gsod_web

Increasing the speed of the function handle gsod.
0 stars 1 forks source link

Maybe split the function into smaller pieces? #2

Open larscaspersen opened 1 year ago

larscaspersen commented 1 year ago

This is just a random thought, but I think the current structure of the function is quite difficult to grasp for new people. I think it would be best to "declutter" the function a bit by splitting it into several smaller functions with clear tasks and then bind everything together in a wrapper function. If you don't think that these intermediate functions should be seen by the package user, you can simply define them after the the big wrapper function in the same script

Nivmizzet95 commented 1 year ago

We could talk about this more - i think i recommended something similar early on in development of the function. I think grasping the function shouldn't be a big problem since the idea was that it would be quite similar to the original handle_gsod() function from the package.