search

Nivrad00 / social-landmines

MIT License
0 stars 0 forks source link

Choices and other state persist after returning to the main menu and starting again #6

Open Nivrad00 opened 3 years ago

Nivrad00 commented 3 years ago

Bruh

Nivrad00 commented 3 years ago

BGs too

Nivrad00 commented 3 years ago

...and history

Nivrad00 commented 3 years ago

  1. Showables not resetting Rakugo was telling the SceneLoader to reload the scene whenever the user returned to the main menu, which SHOULD have reset the showables, but there were two issues: A) SceneLoader needed force_reload=true in order to reload a scene that's already loaded, and B) when SceneLoader told ShowableManager to handle the showables in the newly loaded scene, ShowableManager carried over the shown showables from the previous scene. So I fixed that by adding a reset_showables parameter which is only used when exiting to the main menu.

  2. Choices not resetting Rakugo emits a game_ended signal when the user returns to the main menu. I had ChoiceMenu listen to the signal and clean up the choices.

  3. History/rollback not resetting I need to understand the StoreManager and History system better before addressing this, so the issue is still outstanding. Basically the history doesn't reset at all when you return to the main menu, so looking at the history scene will show lines from the previous gameplay session, and the game will allow you to "roll back" into your previous gameplay session.

Nivrad00 commented 3 years ago

Note - history/rollback also doesn't reset when loading a save