more python upgrade trouble: pycolt and theodore

Nix-QChem / NixOS-QChem

Nix expressions for HPC/Quantum chemistry software packages

MIT License

80 stars 17 forks source link

Closed markuskowa closed 2 months ago

markuskowa commented 2 months ago

Fails now in the evaluation phase with:

error: pytest-runner has been removed as it uses deprecated features of setuptools and is deprecated by upstream

CC @sheepforce

markuskowa commented 2 months ago

I took a quick look. The quick-and-dirty solution is to remove pytest_runner and patch it out, e.g.:

   postPatch = ''
    sed -i '/^setup_requirements/d; /setup_requires/d' setup.py
  '';

Is there a better solution than that?

sheepforce commented 2 months ago

Given the package is somehow build in a standard way (a big "if", I know), the correct solution is the pythonRelaxDepsHook and the pythonRemoveDeps list. For setup.py this should work.

EDIT: Of course only works with pyproject setups. #541 has a workaround more in the spirit of your suggestion.

sheepforce commented 2 months ago

Closed via #541