Refactor receiver for allauth.signals.user_sign_up

Nix-Security-WG / nix-security-tracker

Web service for managing information on vulnerabilities in software distributed through Nixpkgs

31 stars 7 forks source link

Open alejandrosame opened 3 months ago

alejandrosame commented 3 months ago

As noted in https://github.com/Nix-Security-WG/nix-security-tracker/pull/165#discussion_r1682547683, the following refactor will improve the readability of the Github sync code and its test suite:

Move set_groups_for_new_user inside the GithubState class, and connect it to the user_sign_up signal within the constructor.
In the tests, trigger the signal and use @patch to mock the GitHub requests.