hmcl-bin: init at 3.5.3.223

YisuiDenghua commented 2 years ago

Description of changes

Things done

Built on platform(s)
- [x] x86_64-linux
- [x] aarch64-linux
- [x] x86_64-darwin
- [x] aarch64-darwin
[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:
- NixOS test(s) (look inside nixos/tests)
- and/or package tests
- or, for functions and "core" functionality, tests in lib/tests or pkgs/test
- made sure NixOS tests are linked to the relevant packages
[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)
- [x] (Package updates) Added a release notes entry if the change is major or breaking
- [ ] (Module updates) Added a release notes entry if the change is significant
- [ ] (Module addition) Added a release notes entry if adding a new NixOS module
- [ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
[x] Fits CONTRIBUTING.md.

YisuiDenghua commented 2 years ago

@linyinfeng

linyinfeng commented 2 years ago

Tested with nix run github:nixos-cn/flakes/pull/38/head#hmcl-bin

system: "x86_64-linux"
host os: Linux 6.0.0, NixOS, 22.11 (Raccoon), 22.11.20221009.34c5293
desktop environment: gnome 42, wayland

Issues

HiDPI not working
Transparent window decoration not working

Freshly installed vanilla 1.19.2 failed to launch, reporting "GLFW error"

[17:11:52] [Render thread/WARN]: Failed to create window: 
dzu$a: GLFW error 65545: GLX: Failed to find a suitable GLXFBConfig
    at dzu.b(SourceFile:223) ~[1.19.2.jar:?]
    at org.lwjgl.glfw.GLFWErrorCallbackI.callback(GLFWErrorCallbackI.java:43) ~[lwjgl-glfw-3.3.1.jar:build 7]
    at org.lwjgl.system.JNI.invokePPPP(Native Method) ~[lwjgl-3.3.1.jar:build 7]
    at org.lwjgl.glfw.GLFW.nglfwCreateWindow(GLFW.java:2024) ~[lwjgl-glfw-3.3.1.jar:build 7]
    at org.lwjgl.glfw.GLFW.glfwCreateWindow(GLFW.java:2197) ~[lwjgl-glfw-3.3.1.jar:build 7]
    at dzu.<init>(SourceFile:93) ~[1.19.2.jar:?]
    at fah.a(SourceFile:21) ~[1.19.2.jar:?]
    at efu.<init>(SourceFile:484) ~[1.19.2.jar:?]
    at net.minecraft.client.main.Main.a(SourceFile:205) [1.19.2.jar:?]
    at net.minecraft.client.main.Main.main(SourceFile:51) [1.19.2.jar:?]

YisuiDenghua commented 2 years ago

Tested with nix run github:nixos-cn/flakes/pull/38/head#hmcl-bin

* system: `"x86_64-linux"`

* host os: `Linux 6.0.0, NixOS, 22.11 (Raccoon), 22.11.20221009.34c5293`

* desktop environment: gnome 42, wayland

Issues

1. HiDPI not working

2. Transparent window decoration not working
   ![image](https://user-images.githubusercontent.com/11229748/195300850-4f80507a-ebe3-4808-be6e-b5de87828c7c.png)

3. Freshly installed vanilla 1.19.2 failed to launch, reporting "GLFW error"
   ![image](https://user-images.githubusercontent.com/11229748/195302458-60a1adf8-819f-4dc2-b2e7-f50cd5aa68aa.png)
   ```
   [17:11:52] [Render thread/WARN]: Failed to create window: 
   dzu$a: GLFW error 65545: GLX: Failed to find a suitable GLXFBConfig
       at dzu.b(SourceFile:223) ~[1.19.2.jar:?]
       at org.lwjgl.glfw.GLFWErrorCallbackI.callback(GLFWErrorCallbackI.java:43) ~[lwjgl-glfw-3.3.1.jar:build 7]
       at org.lwjgl.system.JNI.invokePPPP(Native Method) ~[lwjgl-3.3.1.jar:build 7]
       at org.lwjgl.glfw.GLFW.nglfwCreateWindow(GLFW.java:2024) ~[lwjgl-glfw-3.3.1.jar:build 7]
       at org.lwjgl.glfw.GLFW.glfwCreateWindow(GLFW.java:2197) ~[lwjgl-glfw-3.3.1.jar:build 7]
       at dzu.<init>(SourceFile:93) ~[1.19.2.jar:?]
       at fah.a(SourceFile:21) ~[1.19.2.jar:?]
       at efu.<init>(SourceFile:484) ~[1.19.2.jar:?]
       at net.minecraft.client.main.Main.a(SourceFile:205) [1.19.2.jar:?]
       at net.minecraft.client.main.Main.main(SourceFile:51) [1.19.2.jar:?]
   ```

Tested with nix-build -E 'with import <nixpkgs> { }; callPackage ./path/to/default.nix { }'

system 1: "x86_64-linux" host os: Linux 6.0.0, NixOS, 22.11 (Raccoon), 22.11.20221013.3c76783 desktop environment: gnome 43, wayland

system 2:"x86_64-darwin" host os: Darwin Kernel 21.6, macOS 12.1 (Monterey)

Sorry, I can't reproduce the bug you mentioned.

NixOS-CN / flakes