search

NixOS / bundlers

MIT License
93 stars 12 forks source link

Incorrect versions in some bundler outputs #10

Open sellout opened 1 year ago

sellout commented 1 year ago

It looks like some bundlers are dropping the leading 0. for pre-1.0 versions.

Here it is for a project of mine – the toDEB and toRPM results both say the version is 1.0, while toDockerImage has the correct 0.1.0 version.

$ nix bundle --bundler github:NixOS/bundlers#toDEB
$ nix bundle --bundler github:NixOS/bundlers#toDockerImage
$ nix bundle --bundler github:NixOS/bundlers#toRPM
$ ls *bash-strict-mode*
bash-strict-mode-0.1.0.tar.gz

deb-single-bash-strict-mode/:
.  ..  bash-strict-mode_1.0_amd64.deb

rpm-single-bash-strict-mode/:
.  ..  bash-strict-mode-1.0-1.x86_64.rpm
$
dpc commented 3 months ago

How do I control the versions on the deb and rpm bundlers anyway?

I have a bunch of binaries that get correct versions when the normal wrapped binaries are produced, but rpm and deb just put 1.0: https://github.com/fedimint/fedimint/releases/tag/v0.3.0-rc.2

sellout commented 3 months ago

Ah! That might be the actual problem – not that the leading component is dropped, but that RPMs and DEBs always get 1.0.