search

NixOS / bundlers

MIT License
93 stars 12 forks source link

Fix default bundler not working with nix 2.8 #4

Closed MaeIsBad closed 2 years ago

MaeIsBad commented 2 years ago

I don't actually know what the pre Nix2.6 bundler API was, I simply tested this by trying bundle hello with the command nix bundle nixpkgs#hello --bundler .# while having nixpkgs#nixVersions.nix_2_{5,6,7,8} in path. This seems to work with the listed nix versions, but there might be some other cases where it doesn't. I'm not knowledgeable enough to tell.

This fixes https://github.com/NixOS/bundlers/issues/3

tomberek commented 2 years ago

There was a recent change to findAlongAttrPath which does not call functors in flakes that might interact with the compatibility hack or its removal (not sure at the moment) at certain Nix versions.

Ultimately I’d like to simply remove the compat to vastly simplify the repo.

Ref: https://github.com/NixOS/nix/commit/d89840b103e57e81e5245c3fe9edfbf7c3477ad5