search

NixOS / cabal2nix

Generate Nix build instructions from a Cabal file
https://haskell4nix.readthedocs.io
Other
354 stars 153 forks source link

gtk3 package has incorrect override #145

Open peti opened 9 years ago

peti commented 9 years ago

The gtk3 library has pkgconfigDepends = [ gtk3 ], but for some reason hackage2nix adds a gtk3 = null override even though gtk3 exists in pkgs and is the correct choice to fulfill this dependency.

peti commented 9 years ago

This is probably caused by the fixGtkBuilds function I added as a hack to work around https://github.com/NixOS/cabal2nix/issues/136.

PierreR commented 6 years ago

Is this still an issue. I am trying to build the new version (1.0.0) of haskellPackages.taffybar which is failing with the error: 

Setup: The pkg-config package 'gtk+-3.0' is required but it could not be
found.
purefn commented 6 years ago

@PierreR was just trying to update to taffybar 1.0.0 myself and am running into the same problem.

I'm not sure if it's related to this issue, but using cabal2nix for both cabal://gtk-traymanager-1.0.0 and cabal://taffybar-1.0.0 result in gtk3 not being in the libraryPkgconfigDepends, even though they are in listed in the cabal file with pkgconfig-depends: gtk+-3.0, x11. Other libraries that need gtk3, like leksah, get their libraryPkgconfigDepends set up fine.

After a bit of experimenting with mucking about with the cabal file, it seems that if gtk3 appears as a dependency in build-depends and gtk+-3.0 appears in pkgconfig-depends, then gtk3 will only appear in the libraryHaskellDepends list. If it doesn't appear in build-depends but does show up in pkgconfig-depends, it shows up fine in libraryPkgconfigDepends.

Any ideas how to fix this @peti?