search

NixOS / cabal2nix

Generate Nix build instructions from a Cabal file
https://haskell4nix.readthedocs.io
Other
352 stars 153 forks source link

Add --disable-library-profiling option #582

Open locallycompact opened 1 year ago

locallycompact commented 1 year ago

enableLibraryProfiling = true seems to be the default when I use cabal2nix, can we have an explicit option to set it to false?

locallycompact commented 1 year ago

I made an alternate fix for this by just explicitly writing the attr instead of boolattr for these options, but further to that opinion I think boolattr is prone to breakage because we can never assume how nixpkgs will interpret a missing key into configure options, so in the interest of discoverability I don't think boolattr is a good idea.

https://github.com/NixOS/cabal2nix/pull/583

locallycompact commented 1 year ago

Ok I just changed it to make boolattr always write out.