search

NixOS / calamares-nixos-extensions

NixOS calamares [maintainer=@vlinkz]
25 stars 20 forks source link

Use proxy when installing, if proxy is set #29

Open FriedrichAltheide opened 4 months ago

FriedrichAltheide commented 4 months ago

It is currently not possible to install NixOS using calamares when behind a proxy, even when creating a custom iso with proxy environment variables set.

With the proposed changed: If a proxy is configured using the http_proxy, https_proxy as well as HTTP_PROXY and HTTPS_PROXY environment variables these environment variables are forwarded to the nixes-install command.

FriedrichAltheide commented 2 months ago

@vlinkz any thoughts on this PR?

FriedrichAltheide commented 1 month ago

@vlinkz any kind of feedback would be appreciated

FriedrichAltheide commented 1 month ago

@RaitoBezarius could you please review this PR?

RaitoBezarius commented 1 month ago

I'm sorry @FriedrichAltheide, I'm keeping my contributions to their minimum until the governance crisis is solved in the NixOS project. The change is non-trivial and so, this will have to wait.

vlinkz commented 1 month ago

Sorry haven't had a chance to review this properly, from a quick look it seems fine. I'll try to test it out later today

FriedrichAltheide commented 1 week ago

Tested the installation once more in an environment where internet is only accessible using a proxy.