search

NixOS / experimental-nix-installer

An experimental fork of the Determinate Nix Installer to explore upstreaming.
GNU Lesser General Public License v2.1
25 stars 2 forks source link

during next sync, keep an eye on `upgrade-nix-store-path-url` change #14

Open abathur opened 4 months ago

abathur commented 4 months ago

Upstream adopted a new nix setting that enables them to declare/host their own source for the ~stable version of Nix. This was added in:

https://github.com/DeterminateSystems/nix-installer/pull/772

We'll either need to revert this or check in with the Nix team to clarify what behavior they want here (and if they, too, would like to set a source outside of nixpkgs for this).

abathur commented 4 months ago

... butt-labeled 🙃

abathur commented 3 months ago

This will be added by the current sync PR to src/action/common/place_nix_configuration.rs:

I'm inclined not to pick this nit in the context of that PR since we probably need at least one more changeset to round up and replace most references to the determinate.systems domain.

Edit: the diff didn't make this clear, but it's added within our #[cfg(not(feature = "nix-community"))] block, so I think this only needs action if the Nix team wants to use its own source for this feature.