search

NixOS / hydra

Hydra, the Nix-based continuous build system
http://nixos.org/hydra
GNU General Public License v3.0
1.1k stars 291 forks source link

Invalid truncation of git hashes #1245

Closed ajs124 closed 10 months ago

ajs124 commented 1 year ago

Describe the bug hydra truncates git revisions too short, in some places. e.g. src/root/common.tt.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://hydra.nixos.org/build/185573231
  2. Take the second hash under Changes: bba87f
  3. Run any git command involving this hash against nixpkgs
  4. Observe that this hash is not unique

Expected behavior Produce valid hashes for a given repository.

dasJ commented 1 year ago

The hash is also truncated in src/root/reproduce.tt