NixOS / hydra

Hydra, the Nix-based continuous build system
http://nixos.org/hydra
GNU General Public License v3.0
1.1k stars 291 forks source link

Documentation is broken #1278

Open poscat0x04 opened 1 year ago

poscat0x04 commented 1 year ago

Describe the bug The documentation isn't rendering properly.

To Reproduce Steps to reproduce the behavior:

  1. Goto the above link

Expected behavior The documentation should render properly

Screenshots

image

Additional context Also, the documentation is quite outdated and non-comprehensive

knedlsepp commented 1 year ago

This is a duplicate of https://github.com/NixOS/hydra/issues/1267 and would be fixed by https://github.com/NixOS/hydra/pull/1268.

drupol commented 1 year ago

I think this issue can now be closed, documentation is displayed correctly.

knedlsepp commented 1 year ago

@drupol it's still broken for me

drupol commented 1 year ago

Could you try with another device? No problem on my side.

Screenshot_20230707-202637_Firefox

drupol commented 1 year ago

I've been testing this on multiple devices and networks, no issue to report so far.

I guess this issue can be closed?

knedlsepp commented 1 year ago

@drupol Tested this on my Android using Chrome and NixOS 23.05 using chromium and it's still broken. I did bisect the problem with a local instance of hydra in December and have a fix for it in https://github.com/NixOS/hydra/pull/1268 which still needs review. Please leave the issue open.

drupol commented 1 year ago

I wish I could reproduce the issue at home. You seem to be the only person complaining about this.

image

knedlsepp commented 1 year ago

You seem to be the only person complaining about this.

Well at least two other people seem to have that problem. The original author of this ticket and another person who did +1 the issue.

I think it's a fallacy that just because "it works on your machine" we should close this ticket.

drupol commented 1 year ago

No, it's not fallacy, I wish I could understand what's going on actually.

Can you do the same kind of screenshot in Firefox ? I would like to see the Network tab just like I posted there.

knedlsepp commented 1 year ago

Can you do the same kind of screenshot in Firefox ?

In the light of "I wish I could reproduce the issue at home" I think it would make more sense for you to try opening this site in chromium than me trying to opening this site in firefox.

drupol commented 1 year ago

hum... I don't like very much the tone of this conversation but ok, I will do it.

drupol commented 1 year ago

Ok I can reproduce it using Chromium.

image

It's weird because the type of these CSS/JS resources are correct.

drupol commented 1 year ago

Anyone can reproduce the issue by doing:

❯ curl -I https://hydra.nixos.org/build/196107287/download/1/hydra/fonts/fonts.css
HTTP/2 200 
strict-transport-security: max-age=15552000
vary: Accept
content-type: cannot open `/nix/store/mp2x9s34n3m2lyd7hk9x15l1sry5qkda-hydra-manual-0.1.20221021.312cb42/share/doc/hydra/fonts/fonts.css' (No such file or directory); charset=cannot open `/nix/store/mp2x9s34n3m2lyd7hk9x15l1sry5qkda-hydra-manual-0.1.20221021.312cb42/share/doc/hydra/fonts/fonts.css' (No such file or directory)
last-modified: Sat, 22 Oct 2022 06:13:00 GMT
content-length: 3620
date: Mon, 10 Jul 2023 15:39:41 GMT
set-cookie: hydra_session=27212460deb4407adab3872f6adb1645739e1576; path=/; expires=Mon, 17-Jul-2023 15:39:41 GMT; HttpOnly; SameSite=Lax
server: Apache/2.4.54 (Unix) OpenSSL/1.1.1s

❯ curl -I https://hydra.nixos.org/build/196107287/download/1/hydra/clipboard.min.js
HTTP/2 200 
strict-transport-security: max-age=15552000
vary: Accept
content-type: cannot open `/nix/store/mp2x9s34n3m2lyd7hk9x15l1sry5qkda-hydra-manual-0.1.20221021.312cb42/share/doc/hydra/clipboard.min.js' (No such file or directory); charset=cannot open `/nix/store/mp2x9s34n3m2lyd7hk9x15l1sry5qkda-hydra-manual-0.1.20221021.312cb42/share/doc/hydra/clipboard.min.js' (No such file or directory)
last-modified: Sat, 22 Oct 2022 06:13:00 GMT
content-length: 10754
date: Mon, 10 Jul 2023 15:41:15 GMT
set-cookie: hydra_session=0052635d3699320dc95669657ee2b6ed0304b596; path=/; expires=Mon, 17-Jul-2023 15:41:15 GMT; HttpOnly; SameSite=Lax
server: Apache/2.4.54 (Unix) OpenSSL/1.1.1s