NixOS / hydra

Hydra, the Nix-based continuous build system
http://nixos.org/hydra
GNU General Public License v3.0
1.1k stars 291 forks source link

hydra-eval-jobs is unnecessarily dropping jobs with "." in their name #1285

Closed JulienMalka closed 1 year ago

JulienMalka commented 1 year ago

Describe the bug Hydra is unnecessarily dropping jobs that have a "." in their name. See here in the code of hydra-eval-jobs: https://github.com/NixOS/hydra/blob/082495e34e094cae1eb49dbfc5648938e23c6355/src/hydra-eval-jobs/hydra-eval-jobs.cc#L246-L250

I've computed that this bug currently induces a drop of 136 jobs in the nixpkgs/trunk jobset.

To Reproduce

The bug can be reproduced by evaluating this flake with hydra-eval-jobs:

{
  description = "A debugging flake";

  outputs = { self }:

    let
      sample = derivation { name = "sample"; builder = "sample"; system = "mysystem"; };
    in
    {
      hydraJobs = {
        "a.b" = sample;
        a.b = sample;
      };
    };
}