NixOS / hydra

Hydra, the Nix-based continuous build system
http://nixos.org/hydra
GNU General Public License v3.0
1.1k stars 291 forks source link

`copyClosureTo`: Use `SubstituteFlag` instead of `bool` #1317

Closed Ericson2314 closed 7 months ago

Ericson2314 commented 7 months ago

This matches Nix (in the same serialization logic in src/libstore/legacy-ssh-store.cc) and adds clarity.

Ericson2314 commented 7 months ago

https://github.com/NixOS/nix/blob/43d55dd15f22376e11ce171699b129c0c6a18745/src/libstore/legacy-ssh-store.cc#L409 here is that serialization code in Nix for reference.

https://github.com/NixOS/nix/blob/43d55dd15f22376e11ce171699b129c0c6a18745/src/libstore/store-api.hh#L82 Here is SubstituteFlag to make sure there isn't any flipped booleans or whatever.