search

NixOS / hydra

Hydra, the Nix-based continuous build system
http://nixos.org/hydra
GNU General Public License v3.0
1.1k stars 291 forks source link

Let tests themselves intentionally leak temp dir #1320

Closed Ericson2314 closed 7 months ago

Ericson2314 commented 7 months ago

By default Yath will clean up temporary files, so the result is the same. But --keep-dirs can be passed to yath test telling Yath to not clean them up instead. This is very useful for debugging.

SuperSandro2000 commented 7 months ago

When building in a nix derivation er seine News to worry to clean up. It's building outside of that a thing? And if so, do we need to worry about quickly flooding people's disks?

Ericson2314 commented 7 months ago

@SuperSandro2000 the title is a bit misleading --- the tests themselves no longer clean up, but the test harness does (unless one opts out), so even in nix-shell by default one will not leak temp stuff.

SuperSandro2000 commented 7 months ago

Noise then this sounds like a no brainer, LGTM