search

NixOS / hydra

Hydra, the Nix-based continuous build system
http://nixos.org/hydra
GNU General Public License v3.0
1.1k stars 291 forks source link

Update perl bindings for nix#9863 #1359

Closed Ma27 closed 4 months ago

Ma27 commented 4 months ago

For https://github.com/NixOS/nix/pull/9863

cc @Ericson2314 @dasJ

Ericson2314 commented 4 months ago

OK the underlying Nix PR is merged!

@Ma27 can you spit this up so the 1st (or 1st and part of 4th) commit is in this PR, and the possibly-behavior-changing middle parts are in a second PR?

I just want to be very cautious and have a nice rollback ready in case something goes wrong :).

Ma27 commented 4 months ago

I just want to be very cautious and have a nice rollback ready in case something goes wrong :).

Sure, this PR only contains the MACHINE_LOCAL_STORE changes. A second PR will be opened in a few minutes.

(or 1st and part of 4th)

Not necessary IMHO: w/o the BINARY_CACHE_STORE it's not necessary to read from hydra.conf and thus the include test doesn't break. Also this seemed to painful to split and push up in the history, so I figured it's OK that way.

Ma27 commented 4 months ago

Done! Required a few changes to the cpp code though.