search

NixOS / hydra

Hydra, the Nix-based continuous build system
http://nixos.org/hydra
GNU General Public License v3.0
1.1k stars 291 forks source link

lazy-load evaluation errors #1363

Open ajs124 opened 4 months ago

ajs124 commented 4 months ago

Closes #1362

delroth commented 4 months ago

Future improvement: IF eval.evaluationerror.errormsg still loads the full errormsg from the DB, when in practice we could get away with just checking for whether it's empty or not (and loading from the DB only on the separate eval error page).

It's likely a slightly more involved fix though, just mentioning it in case you're interested :p

delroth commented 4 months ago

To whoever will merge this: please cherry-pick it on the 2.19 branch so we can easily apply it to hydra.nixos.org.

delroth commented 4 months ago

FWIW we've tested this on hydra.nixos.org for a few days and everything worked fine.

@Ericson2314 can you merge this please?

mweinelt commented 3 months ago

@Ma27 If you know what to do, please give it a shot.

mweinelt commented 3 months ago

The JSON API for jobsets/evals also ships the whole eval errors string, which is utterly pointless. Can we rip that out as well?

curl --header "Accept: application/json" https://hydra.nixos.org/jobset/nixpkgs/staging-next 👻

Ma27 commented 3 months ago

@Ma27 If you know what to do, please give it a shot.

I'll happily do that, but it may take me a few days.