search

NixOS / hydra

Hydra, the Nix-based continuous build system
http://nixos.org/hydra
GNU General Public License v3.0
1.2k stars 306 forks source link

renderInputDiff: Increase git hash length 8 -> 12 #1396

Closed nh2 closed 3 months ago

nh2 commented 4 months ago

See investigation on lengths required to be conflict-free in practice:

https://github.com/NixOS/hydra/pull/1258#issuecomment-1321891677

Reason: Got annoyed / slowed down today again that the commit c716603a shown in https://hydra.nixos.org/build/266559156 shows 404 on Github: https://github.com/NixOS/nixpkgs/commit/c716603a

This immediately made me suspect that somebody rewrote history (security issue), when in fact the commit is just too short.

We should not waste time with such things, so bump the length.

delroth commented 4 months ago

Applied in https://git.lix.systems/lix-project/hydra/commit/8a984efaef2611bcf00b3b5a114acaacb091b553, thanks!