search

NixOS / hydra

Hydra, the Nix-based continuous build system
http://nixos.org/hydra
GNU General Public License v3.0
1.16k stars 298 forks source link

notifications should not be sent to addresses in the commit log #544

Open phi-gamma opened 6 years ago

phi-gamma commented 6 years ago

Contributors via Github can use different email addresses for notifications than the one they commit under. Currently, Hydra grabs the addresses from the commit log [0] [1] to determine who should be notified which might not match the notification preferences.

In any case, all automated email should contain a List-Unsubscribe: header. Whatever contact you put in there should get an address removed from the automated mailings.

[0] https://github.com/NixOS/hydra/blob/master/src/lib/Hydra/Plugin/EmailNotification.pm [1] https://github.com/NixOS/hydra/blob/a4fc292c83e4bffd7da0eb0e64453b52e5a70fcd/src/lib/Hydra/Helper/CatalystUtils.pm#L310

References thanks to @cleverca22 on IRC.

cleverca22 commented 6 years ago 
2018-03-11 08:23:27 < noqqe> "This may be due to 16697 commits by .... "
2018-03-11 08:23:38 < noqqe> yeah probably everyone gets those mails