search

NixOS / jailbreak-cabal

Strip version restrictions from build dependencies in Cabal files.
http://hackage.haskell.org/package/jailbreak-cabal
BSD 3-Clause "New" or "Revised" License
10 stars 11 forks source link

Traverse recursively condition tree components #8

Closed abbradar closed 9 years ago

abbradar commented 9 years ago

This should fix jailbreaking dependencies inside conditionals.

abbradar commented 9 years ago

This has fixed Agda build for me on nixpkgs master and GHC 7.8

abbradar commented 9 years ago

Ouch, I had't done enough research before making a PR and saw https://github.com/peti/jailbreak-cabal/commit/99eac40deb481b185fd93fd307625369ff5e1ec0 now. I guess that means this change is out of question then! Maybe we can mention this in the README to prevent future misunderstandings?

peti commented 9 years ago

There's also https://github.com/peti/jailbreak-cabal/issues/7 and https://github.com/peti/jailbreak-cabal/pull/4. This issue seems to come up frequently. I guess we should document the rationale for the current behavior in the readme or the source code.

abbradar commented 9 years ago

What about a simple comment, like this?

peti commented 9 years ago

Very good. Thank you!