NixOS / mvn2nix-maven-plugin

Generate project-info.json for use with nix's Maven repository generation functions
MIT License
31 stars 21 forks source link

Misses some dependencies when run on K Framework #4

Open taktoa opened 9 years ago

taktoa commented 9 years ago

I am (re-)packaging a decently large Maven project – the K Framework – for Nix. Currently, when I run this tool on that source, i.e.:

wget https://github.com/kframework/k/archive/master.zip
unzip master.zip; cd k-master
mvn org.nixos.mvn2nix:mvn2nix-maven-plugin:mvn2nix
mv project-info.json ../kframework.json
cd ..; rm -r k-master

I get an output JSON file that does not contain the following dependency:

{
    "artifactId": "scala-maven-plugin",
    "groupId": "net.alchim31.maven",
    "version": "3.2.0",
    // ... omitted for brevity ...
    "exclusions": []
}

despite the fact that kore/pom.xml and tiny/pom.xml contain these lines:

<build>
  <plugins>
    <plugin>
      <groupId>net.alchim31.maven</groupId>
      <artifactId>scala-maven-plugin</artifactId>
      <version>3.2.0</version>
      <executions><!-- omitted for brevity --></executions>
      <configuration>
        <args><arg>-Xexperimental</arg></args>
      </configuration>
    </plugin>
  </plugins>
</build>

Sincerely, Remy Goldschmidt

shlevy commented 9 years ago

Looks like this is because of modules, a feature I didn't know about https://maven.apache.org/guides/mini/guide-multiple-modules.html I'll take a look when I get a chance, thanks!

ghost commented 8 years ago

Anything new on the multiple modules support?

shlevy commented 8 years ago

I'm not really actively developing mvn2nix currently, I'll review PRs and consider transferring maintainership though.