search

NixOS / nix-mode

An Emacs major mode for editing Nix expressions.
GNU Lesser General Public License v2.1
298 stars 76 forks source link

New dependency on reformatter not reflected in melpa recipe #178

Closed miangraham closed 1 year ago

miangraham commented 1 year ago

(As of 20230112.1845) nix-mode now depends on the reformatter package but melpa doesn't seem to know about the new addition. This caused an error (No such file or directory reformatter) for me after upgrading nix-mode, which I was able to resolve by explicitly installing reformatter for the first time.

My package installation method is nix via emacs-overlay. This is the relevant change to my config that resolved the error: https://codeberg.org/mian/nixos-config/src/commit/3df07630fbea204b0acd59c1613be1755caadfd5/common/emacs.nix#L67

Over on melpa, the recipe deps observed don't contain the new addition: https://melpa.org/#/nix-mode

I'm green on melpa recipe stuff so not completely sure, but a potential cause looks like reformatter only being added to Package-Requires in nix-format.el instead of the top level nix-mode.el. Either it doesn't pick that up transitively or I'm missing something else.

Thanks for the great package and let me know if I'm filing in the wrong place. Cheers!

miangraham commented 1 year ago

Should have looked at outstanding PRs first. This should be fixed by https://github.com/NixOS/nix-mode/pull/177.

miangraham commented 1 year ago

Confirmed fixed by #177. Thanks!