search

NixOS / nix-mode

An Emacs major mode for editing Nix expressions.
GNU Lesser General Public License v2.1
298 stars 76 forks source link

nix-flake: set default major-mode of flake.lock to js-mode #186

Closed jian-lin closed 1 year ago

jian-lin commented 1 year ago

for benefits such as syntax highlighting

cc @matthewbauer

akirak commented 1 year ago

Now that Emacs 29 is shipped with json-ts-mode, I think this configuration task should be left to the user. The user should be able to choose between json-ts-mode, js-mode (or js-json-mode), or its alternative major mode created by third-party.

jian-lin commented 1 year ago

I think this configuration task should be left to the user.

If users want to use another major-mode, this PR does not prevent them from doing so.

However, if they have no specific needs, this PR improves their experiences by providing a default major-mode.

akirak commented 1 year ago

However, if they have no specific needs, this PR improves their experiences by providing a default major-mode.

You are right, thanks.