NixOS / nix-pills

Creative Commons Attribution Share Alike 4.0 International
373 stars 116 forks source link

Remove usage of `baseInputs` to avoid confusion? #219

Open martin-braun opened 1 year ago

martin-braun commented 1 year ago

I'm coming from #87. Reading through Nix Pills, I can still find numerous references to baseInputs that caused great confusion on my end as a newcomer when transitioning to mkDerivation, please take the time to get rid of things that aren't used in the mkDerivation at all, because you end up in false assumptions from the things you learned previously.

Unlearning is significantly harder than learning.

MikHulk commented 3 months ago

Yes the sentence suggests that's an alternative but the code without this change doesn't work. It would be much better to insist on alternatives: merge buildInputs vs keep them in two attributes.