Open edolstra opened 2 months ago
we could already improve on the user experience here by warning the user to avoid such paths.
This is a pre-flakes behavior that would be a breaking change.
we could already improve on the user experience here by warning the user to avoid such paths.
I believe this would trigger quite often, and without being all that actionable for most users.
We'd better address the root cause, which is putting flakes in the store in the first place, making this problem prevalent instead of niche.
We could do so with either
Describe the bug
In a flake with a derivation attribute like
the tree gets copied into the store as
/nix/store/<hash1>-<hash2>-source
. This is because (pre lazy-trees) the basename of the tree is/nix/store/<hash2>-source
.This double-copying is obviously undesirable, but we can't fix it without a breaking change (i.e. without changing derivation paths).
On lazy-trees, we can at least avoid writing
/nix/store/<hash2>-source
to disk, but we do need to hash the input to compute<hash2>
. (See https://github.com/NixOS/nix/commit/c5ae41d8be6eb391ae39de9cce58b5e6b9e8085b.)Steps To Reproduce
Expected behavior
A clear and concise description of what you expected to happen.
nix-env --version
outputAdditional context
Add any other context about the problem here.
Priorities
Add :+1: to issues you find important.