NixOS / nix

Nix, the purely functional package manager

https://nixos.org/

GNU Lesser General Public License v2.1

12.28k stars 1.48k forks source link

No global eval settings in `libnixexpr` #10913

Closed Ericson2314 closed 3 months ago

Ericson2314 commented 3 months ago

Motivation

Progress on #5638

Context

There is still a global eval settings, but it pushed down into libnixcmd, which is a lot less bad a place for this sort of thing.

Priorities and Process

Add :+1: to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

edolstra commented 3 months ago

Is there a use case where we could have multiple EvalState instances with different settings?

Ericson2314 commented 3 months ago

@edolstra Evaluating completely independent things. Could be part of an application with a long-lived process, or it could be part of the unit tests. The latter one may be just testing, but it's a fully non-hypothetical real one today.

nixos-discourse commented 3 months ago

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2024-06-24-nix-team-meeting-minutes-155/47739/1