search

NixOS / nix

Nix, the purely functional package manager
https://nixos.org/
GNU Lesser General Public License v2.1
11.47k stars 1.44k forks source link

Fix a compile error on windows #10927

Closed poweredbypie closed 2 weeks ago

poweredbypie commented 2 weeks ago

Context

There's a compile error on windows in the most current commit due to typing a parenthesis rather than a curly bracket.

Priorities and Process

Add :+1: to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

roberth commented 2 weeks ago

Thanks! We've previously decided not to CI the Windows bits, not to hinder progress on the supported platforms, but we'll add it at some point.

poweredbypie commented 2 weeks ago

Thanks. I'll try to implement CI for Windows if I have time to read up on it!

Ericson2314 commented 2 weeks ago

@poweredbypie it's less something that needs to be implemented than just a matter of flipping a switch (shuffling some code around in flake.nix, it's already in `hydraJobs). It will be easier to think about after we've switched to Meson and there are not two build systems in flight.