search

NixOS / nix

Nix, the purely functional package manager
https://nixos.org/
GNU Lesser General Public License v2.1
12.28k stars 1.48k forks source link

Accept response from gitlab api with more than one entry in json #10943

Closed pineapplehunter closed 3 months ago

pineapplehunter commented 3 months ago

Motivation

In #10811 it is assumed that the json response from Gitlab API is a single item, but I found that it may contain more than one entry and was causing nix flake update to fail after version 2.23.0. This should fix the issue with flake updates.

Context

Priorities and Process

Add :+1: to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

Kranzes commented 3 months ago

I find this to be pretty critical, can we get this in a minor release once it's merged?

github-actions[bot] commented 3 months ago

Successfully created backport PR for 2.23-maintenance:

nixos-discourse commented 3 months ago

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2024-06-24-nix-team-meeting-minutes-155/47739/1

andrevmatos commented 3 months ago

Oh, that's why my nix flake update has been failing for a couple of weeks! :sweat_smile: As a workaround, in the meantime, I'm using nix run nixpkgs#nixVersions.nix_2_22 flake update