search

NixOS / nix

Nix, the purely functional package manager
https://nixos.org/
GNU Lesser General Public License v2.1
11.45k stars 1.44k forks source link

Restore commit-lock-file-summary rename for consistency #10988

Closed cole-h closed 2 days ago

cole-h commented 2 days ago

It was originally renamed in https://github.com/NixOS/nix/pull/10691, but https://github.com/NixOS/nix/pull/9063 accidentally removed the new name and alias.

Motivation

Context

Priorities and Process

Add :+1: to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

cole-h commented 2 days ago

(Drafted so I can add a test)

cole-h commented 2 days ago

OK, test added as the first commit. For me, it fails when I check out that commit, and passes when I check out the tip of this branch.

I also noticed a little weirdness with aliases to settings and filed a bug here: https://github.com/NixOS/nix/issues/10989. Maybe this is intended / already has an open issue prior to mine / has been discussed before; if so, feel free to point me there (but I'll make the argument that if the "real" setting works as a flag (i.e. --commit-lock-file-summary), its aliases should also work as a flag (i.e. --commit-lockfile-summary).