NixOS / nix

Nix, the purely functional package manager

https://nixos.org/

GNU Lesser General Public License v2.1

12.9k stars 1.53k forks source link

Bump fetcher cache version #11915

Closed roberth closed 4 days ago

roberth commented 6 days ago

We're getting more reports in

https://github.com/NixOS/nix/issues/10985

It appears that something hasn't gone right process-wise. I find this mistake not to be worth investigating, but rather something to pay attention to going forward.

Let's nip this in the bud.

Closes https://github.com/NixOS/nix/issues/10985

Priorities and Process

Add :+1: to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

edolstra commented 6 days ago

I don't see how this will fix the problem though. The domain attribute was introduced in the same commit that renamed the fetcher cache to v2 (aad11f44962aa49a61cf73155d61204ad48e42e3). So renaming it to v3 will presumably just trigger the same issue.

roberth commented 6 days ago

Any other ideas?

edolstra commented 6 days ago

I guess it could have happened if they were running lazy-trees between August and October of last year? It briefly had a fetcher-cache-v2.sqlite without the domain field (from c0d33087c8b39aba4dbb797be98f05a52c4358fa to 144987e28a7cb87e6875194039d53b05dca461b7).

roberth commented 4 days ago

devenv shipped that code, see https://github.com/NixOS/nix/issues/10985#issuecomment-2491233450 This explains the limited but not insignificant number of reports. Note that devenv targets novice users, so this probably has a high ratio of unreported occurrences as well. We should fix this, and the expedient way to do it is to bump the version.