search

NixOS / nix

Nix, the purely functional package manager
https://nixos.org/
GNU Lesser General Public License v2.1
12.27k stars 1.48k forks source link

sshPublicHostKey support was added to Nix's machine parser, from Hydra, but left unimplemneted #4190

Open grahamc opened 3 years ago

grahamc commented 3 years ago

Hydra has a machine file with a seventh field, the sshPublicHostKey https://github.com/NixOS/hydra/blob/79d34ed7c93af2daf32cf44ee0e3e0768f13f97c/src/hydra-queue-runner/hydra-queue-runner.cc#L111. This was ported to nix: https://github.com/NixOS/nix/blob/7714d9a943bd36e984a1531fbc367ce124fc94da/src/libstore/machines.cc#L110

but not the actual implementation which uses the field: https://github.com/NixOS/hydra/blob/869671e55630e1348cb7e8e1a3eb43883ea6cba7/src/hydra-queue-runner/build-remote.cc#L59-L65

stale[bot] commented 3 years ago

I marked this as stale due to inactivity. → More info