search

NixOS / nixfmt

The official (but not yet stable) formatter for Nix code
https://nixfmt.serokell.io
Mozilla Public License 2.0
920 stars 40 forks source link

RFC 166 implementation tracking issue #153

Open infinisil opened 8 months ago

infinisil commented 8 months ago

Now that RFC 166 is accepted, let's commence with the implementation!

Here's a very rough todo-list, most of which will be fairly quick.

Ping @piegamesde @tomberek @0x4A6F @Sereja313 @dasJ

tomberek commented 8 months ago

Proposal: do reformatting in the NixOS org with a few non-nixpkgs repos first

Atemu commented 8 months ago

Proposal: After what @tomberek suggested is done and successful, do formatting of Nixpkgs in a subset of Nixpkgs first (i.e. pkgs/by-name/)

Kreyren commented 8 months ago

https://github.com/Kreyren/nixos-config/blob/dc0dbb6f15c4d8656b26220645793a06d10fa3ea/nixos/users/kreyren/home/modules/prompts/starship/starship.nix#L3-L14 (best seen in raw)

RFC @infinisil Is this known issue that is actionable by RFC166? I read through it don't see it anywhere (if tabs are used it causes the prompt to be rendered with long indentation instead of the indentation being removed from the declaration, affects most of nix modules)

piegamesde commented 8 months ago

This looks unlikely to be a desired output according to the RFC format. Now that the PR is merged, please simply open an issue for it.

nixos-discourse commented 8 months ago

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/formatting-team-meeting-2024-03-19/41845/1

Kreyren commented 7 months ago

This looks unlikely to be a desired output according to the RFC format. Now that the PR is merged, please simply open an issue for it. -- @piegamesde (https://github.com/NixOS/nixfmt/issues/153#issuecomment-2002441845)

Referencing comment by @roberth in https://github.com/NixOS/nix/issues/8874#issuecomment-1704358732

Got referred to RFC166 from RFC137 about this issue in relation to addressing https://github.com/NixOS/nix/issues/8874

piegamesde commented 7 months ago

@Kreyren please just open a new issue with input, current output and desired output and I'll look at it. Simply linking to weird looking code does not give me enough context to understand the situation.

nixos-discourse commented 7 months ago

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/tweag-nix-dev-update-56/43035/1

nixos-discourse commented 6 months ago

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nixf-tidy-static-semantic-linter-for-nix-help-me-to-integrate-it-with-github-actions-pr-reviews/43911/2

nixos-discourse commented 3 months ago

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/enforcing-nix-formatting-in-nixpkgs/49506/3

nixos-discourse commented 3 months ago

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/enforcing-nix-formatting-in-nixpkgs/49506/8

nixos-discourse commented 3 months ago

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/satisfaction-survey-from-the-new-rfc-166-formatting/49758/1

nixos-discourse commented 3 months ago

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/why-does-the-nixos-infrastructure-have-to-be-hosted-in-a-centralized-way/46789/36

gabyx commented 2 months ago

@infinisil et. al.: :heart: Thanks a lot for pushing this and the hard work on it! I am happy if that debate is soon over =) and we have some opiniated way to not disgress again and again into whitespace debates in PRs. Having a 90% solution is so much better then having nothing which puts Nixpkgs back to middleages.