--check re-deployment of an AWS security group with a port wildcard (1-65535) grant fails due to None being fed to int()

NixOS / nixops-aws

GNU Lesser General Public License v3.0

53 stars 37 forks source link

--check re-deployment of an AWS security group with a port wildcard (1-65535) grant fails due to None being fed to int() #61

Open deepfire opened 6 years ago

deepfire commented 6 years ago

When --check mode is used to _re_deploy a EC2 Security Group with has a port wildcard grant (1-65535) fails, because boto returns (None, None) as the port range.

Sadly, I no longer have the logs to prove this, but the relevant piece of code is this:

https://github.com/NixOS/nixops/blob/master/nixops/resources/ec2_security_group.py#L129

deepfire commented 6 years ago

cc @domenkozar

domenkozar commented 6 years ago

@deepfire which gets me thinking, does Amazon provide some sort of UID that we could rely on instead of diffing values?