search

NixOS / nixops

NixOps is a tool for deploying to NixOS machines in a network or cloud.
https://nixos.org/nixops
GNU Lesser General Public License v3.0
1.87k stars 364 forks source link

Add flake8 linter #1343

Closed adisbladis closed 4 years ago

adisbladis commented 4 years ago

This is mainly an addition to avoid import loops by detecting unused imports early and force them to be removed.

Flake8 also detects other things which may be of interest of us such as bad variable naming, cyclomatic complexity (this one is of great interest to me at least).

We opt out of a number of checks that conflict with black's auto formatting rules.

grahamc commented 4 years ago

Ratchet is whatever, but the requirements.txt for the docs is out of date

grahamc commented 4 years ago

Ignoring the ratchet since this is strictly an improvement, and a few deleted imports shouldn't be penalized.