search

NixOS / nixops

NixOps is a tool for deploying to NixOS machines in a network or cloud.
https://nixos.org/nixops
GNU Lesser General Public License v3.0
1.87k stars 364 forks source link

wait_for_ssh doesn't #1374

Closed grahamc closed 4 years ago

grahamc commented 4 years ago

wait_for_ssh assumes self.wait_for_up(callback=lambda: self.log_continue(".")) waits correctly, but wait_for_up assumes nixops.util.wait_for_success(self._ping, timeout=timeout, callback=callback) waits correctly but wait_for_success can return False if it times out!

I wonder if wait_for_success should raise if it times out?

grahamc commented 4 years ago

okay I think I'm confused :x

grahamc commented 4 years ago

:upside_down_face: