Open PAI5REECHO opened 1 year ago
Me neither, if what you're saying is that something was skipped because of the error.
Stopping a deployment half way is incompatible with declarative deployments that do not specify dependencies (we don't) and it is also incompatible with the idea of letting the distributed system converge towards an acceptable (or fully) operational state. That said, using the deployment process for feedback about the system seems useful. Did your deployment skip anything because of the error? If so, that would be an issue that needs correcting.
Also we shouldn't be emitting a stack trace for this type of error and the log should be clear about what did and did not happen.
TODO
Did your deployment skip anything because of the error?
Yes, the system activation fails due to a failing or pending systemd service, so no changes to the system are applied which is unexpected. Activation shouldn't depend on the health of systemd services.
Whenever a nixops deployment is made on a system with a systemd service in a activating (auto-restart) or failed state the deployment fails. I don't understand why nixops is designed in this way though.