search

NixOS / nixops

NixOps is a tool for deploying to NixOS machines in a network or cloud.
https://nixos.org/nixops
GNU Lesser General Public License v3.0
1.86k stars 365 forks source link

ImmutableValidatedObject: Support nested Mapping types #1573

Closed talyz closed 11 months ago

talyz commented 1 year ago

Since typeguard was updated in #1569, the use of deployment.keys (+ a few required options in nixops-gce, like bootstrapImage), has been broken. This is because typeguard now inspects the type of mapping containers (Mapping[str, KeyOptions] and such) and nested such containers weren't handled by ImmutableValidatedObject.

This also improves the handling of nested sequences and fixes their associated test.

fixes #1570

pSub commented 11 months ago

This fixes #1570 for me. Is there anything that prevents this from being merged and released? Maybe the mypy-ratchet check?

Would be great to have a release with this bug fixed!