NixOS / nixos-hardware

A collection of NixOS modules covering hardware quirks.
Creative Commons Zero v1.0 Universal
2.09k stars 646 forks source link

Pinephone/Pinephone Pro Support #716

Open luigi311 opened 1 year ago

luigi311 commented 1 year ago

Just saw librem5 support added so figured i would mention bringing in support for the Pine64 mobile phone devices. There is currently support for the Pinephone and there is a PR for Pinephone Pro in the mobile-nixos repo but it might be better to bring in support to the official nixos hardware instead of just leaving it there.

One of the big benefits i see in their repo is they have built their own installer so its possible to build an image and install it on to the sd card and the installer will prompt for all the information and flash it onto the emmc.

samueldr commented 1 year ago

Mobile NixOS is a bit more than that,

What Mobile NixOS brings to your everyday system is those three main things:

The second point includes, for the Pinephones (and would help with the Librem 5) a generation selection mechanism for stage-2 that is usable without requiring access to serial.

Why would you want a touch-based stage-1 implementation? For LUKS passphrase input for FDE.

Though, I don't think anyone should see this a preventing them to try and do things in other ways. They are only one solution to different problems.

Though note that some parts can be used independently. For example, I use the touch-based stage-1 implementation on my Steam Deck so I can input the FDE passphrase on boot without requiring a physical keyboard.

(That's, as you hinted, in addition to working on making other helpful parts like the on-device installer system...)

luigi311 commented 1 year ago

Thats all good information, i love the installer you have created since it makes it easier to get started on a mobile device like the PP. All three of those benefits that mobile NixOS sound great and seems like a great reason for Mobile NixOS to exist and continue existing but im not sure if hardware configurations should exist there permanently atleast for the more linux focused devices such as the PP/PPP and/or librem devices.

We can add the configurations on here and then point to Mobile NixOS for documentation/instructions for getting an image with the installer and with all the other benefits that Mobile NixOS provides that you mentioned.

tomfitzhenry commented 1 year ago

+1 to the benefits of stage-2 generation selection, and to trying different solutions to this new field, especially for devices that more easily integrate with Linux environments (Pinephone/Librem).

Re touch-based stage-1 implementation for FDE, I'm in the process of adding PostmarketOS's unl0kr to nixpkgs: https://github.com/NixOS/nixpkgs/pull/218441