search

NixOS / nixos-hardware

A collection of NixOS modules covering hardware quirks.
Creative Commons Zero v1.0 Universal
2.04k stars 631 forks source link

Enhancement: enabling PowerManagement on Laptops #989

Closed betalars closed 4 months ago

betalars commented 4 months ago

As reccomended by the nixos wiki page on laptops, you want to enable PowerManagement on laptops. And - if understand this correctly - this is a collection of weird configuration quirks you generally want to enable on specific devices, including laptops.

So my suggestion is to enable this option when you enable quirks for a laptop.

As an alternative solution, I also suggested adding it to the hardware-configuration generated by nixos-generate-config upon install. This issue can be found over on nixpkgs

Mic92 commented 4 months ago

We already do this for laptops: https://github.com/NixOS/nixos-hardware/blob/cde8f7e11f036160b0fd6a9e07dc4c8e4061cf06/common/pc/laptop/default.nix#L9

betalars commented 4 months ago

I was just coming here to close this myself due to User Error. Somehow the hardware-module line got lost in my configuration and I did not realize this.