search

NixOS / nixos-homepage

Sources for nixos.org
https://nixos.org
286 stars 305 forks source link

Fix YAML for cron workflow #1355

Closed DanielSidhion closed 3 months ago

DanielSidhion commented 3 months ago

I noticed the cron workflow has been broken for a while, when I was looking into whether some changes I made on the Nixpkgs/NixOS manual had already propagated to the homepage.

The YAML file had an error because it started the if condition with a ! without escaping it. The GitHub docs mention this case:

You must always use the ${{ }} expression syntax or escape with '', "", or () when the expression starts with !, since ! is reserved notation in YAML format.

This PR fixes this by following the same syntax as shown in the example in the GitHub docs link above.

thilobillerbeck commented 3 months ago

Looks good! Thx for the fix

I just wait with merging until #1352 is resolved