search

NixOS / nixos-homepage

Sources for nixos.org
https://nixos.org
286 stars 305 forks source link

Adjust cover video to work with latest nixpkgs #1387

Closed garbas closed 2 months ago

garbas commented 2 months ago

fixes #1221

garbas commented 2 months ago

@Welding-Torch @NobbZ Can you verify that an example now works also for you?

github-actions[bot] commented 2 months ago

🚀 Deployed on https://6617af13b07fb16c9610248c--nixos-homepage.netlify.app

NobbZ commented 2 months ago

I still do not like that there is no hint about what nixpkgs version this was tested against.

To be honest, relying on the nix path pointing to a compatible version of nixpkgs (it existing at all) and breaking if not, is very bad PR for the "reproducibility" we always try to hold up as the primary thing.

Of course, we do not want to introduce flakes here, unnecissarily increasing complexity of the demo, though at least mentioning that it was tested against a certain channel version, and that far older and far newer versions might require adjustements.