Closed dpeachpeach closed 1 month ago
Thanks for reporting, I'll take care of it.
Some context since I've also been hunting for the appropriate fix here:
All of those links are under https://nixos.org/learn/manual/nix/stable
which is redirected by https://github.com/NixOS/nixos-homepage/blob/5f00e553a8230ead255ee6b1f3d274fc4f6bb727/public/netlify.toml#L115-L117 to https://nix.dev/manual/nix/stable/stable
.
The first stable
gets transformed into the current stable numeric version by mutableRedirect
during the nix.dev installPhase
; this transformation is reified as a netlify redirect during the CI workflow. The resulting link 404s, as <version>/stable
is not a valid path.
This is yet more reason to unify the docs-related infrastructure across repositories; see https://github.com/NixOS/nixos-homepage/pull/1141 for earlier discussion.
This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/2024-05-31-documentation-team-meeting-notes-130/46261/1
Introduce your stance A number of hyperlinks on the nixos.org website seem to be redirecting incorrectly. I saw that there was a PR that was merged that was supposed to solve this in #1447, but it seems like there still is a problem.
Describe the issue Multiple links on this page: https://nixos.org/learn/
Such as all of the ones in this screenshot:
Direct to links such as: https://nix.dev/manual/nix/2.18/stable/installation/installing-binary. Which returns a page not found error:
When the 'functional' link seems to be: https://nix.dev/manual/nix/2.18/installation/installing-binary
Page links
Additional context I know that nix.dev is separate from this website, so I'm not sure where the burden of 'improvement' falls under. However, these links are still broken and I just wanted to alert someone. I could start up a PR to fix this pretty quickly as well if I required but I just wanted to confirm that this wasn't fixed. Thank you!